Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename types likely to clash to include ImplicitUsings by default #1491

Closed
bruno-garcia opened this issue Feb 18, 2022 · 8 comments
Closed
Labels
Feature New feature or request Good First Issue Good for newcomers
Milestone

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Feb 18, 2022

@bruno-garcia bruno-garcia added this to the 4.0.0 milestone Feb 18, 2022
@bruno-garcia bruno-garcia added the Feature New feature or request label Feb 18, 2022
@bruno-garcia bruno-garcia moved this to Needs Discussion in Mobile & Cross Platform SDK Feb 18, 2022
@mattjohnsonpint mattjohnsonpint moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Mar 17, 2022
@mattjohnsonpint
Copy link
Contributor

Clear example, Sentry.Span conflicting with System.Span<T>.

Before simply renaming everything, we should re-think our type names within the context of implict/global usings. Does the whole .NET ecosystem need to re-think this? Are these conversations already happening, and can we align to what others might be doing?

@mattjohnsonpint mattjohnsonpint moved this from Backlog to Needs Discussion in Mobile & Cross Platform SDK Mar 17, 2022
@mattjohnsonpint
Copy link
Contributor

Discussed. I think we should do this for the next major (4.0), especially in light of global usings. Another good example is Transaction, which should be SentryTransaction.

Lets do this as part of reviewing the public API surface for 4.0.

@mattjohnsonpint mattjohnsonpint moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Apr 21, 2022
@mattjohnsonpint
Copy link
Contributor

See also #1585

@bruno-garcia bruno-garcia modified the milestones: 4.0.0, 5.0.0 Nov 6, 2023
@bitsandfoxes bitsandfoxes added this to GDX Nov 20, 2023
@bruno-garcia bruno-garcia modified the milestones: 5.0.0, 4.0.0 Dec 2, 2023
@bruno-garcia
Copy link
Member Author

We should give this one a try now on 4.0.0.

Adding ImplicitUsings to a project should allow you do do a basic SentrySdk.Init call and basic SentrySdk.CaptureException without having to do any using Sentry or Sentry.Anything

Wdyt @bitsandfoxes @jamescrosswell ?

@jamescrosswell
Copy link
Collaborator

Wdyt @bitsandfoxes @jamescrosswell ?

From memory, we initially pushed this back to 5.0.0 from 4.0.0 to descope the 4.0 release a bit and make sure we'd be able to ship it around the same time as the .net8.0 release.

I think we've derisked that now so could potentially put this one back in there. It'd be an easy first issue to pick up.

@bruno-garcia
Copy link
Member Author

Since the 3.x SDK works fine on .NET 8, releasing 4.0.0 is not time sensitive. So if we want to extend the scope/time to take advantage of the major bump, we can

@bitsandfoxes
Copy link
Contributor

What about Scope?

@bruno-garcia
Copy link
Member Author

What about Scope?

Since that'll be more prevalent going forward, to keep it in sync with most SDKs, I think it's fine we keep it as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Good First Issue Good for newcomers
Projects
Status: Done
Archived in project
Development

No branches or pull requests

4 participants