-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert adding Sentry to global usings #1487
Comments
|
IMO adding Sentry to global usings was a mistake. This library is used only in the composition root in 99% of the cases. The potential for real naming clashes ( |
wouldnt this suffice as a opt-out ?
|
Good tip, TIL. Worth adding to: https://docs.sentry.io/platforms/dotnet/troubleshooting/#implicit-usings |
We discussed and agreed to revert this feature, until we release 4.0 that will include renaming some types prone to conflict. |
The latest Release 3.14.0 comes with the following feature:
We do have implicit usings enabled, with the intention was that only the often used "standard"-namespaces are added there.
Sentry on the other hand is a namespace which we use exactly once in our ASP.NET Core API projects: when configuring Sentry on startup.
For me as an "end user" of this library it does make absolutely no sense to have Sentry in the global usings.
Main issue:
The main conflict here is
Sentry.User
. I guess aUser
is not a really uncommon name for a class. Now, with the latest update we have a lot of ambiguous references between Sentry.User and our Domain-User. As a workaround I'd have to explicitly reference our Domain-User in a ton of classes over multiple projects. Which I really don't want to do.So I vote for removing Sentry from global usings again.
The text was updated successfully, but these errors were encountered: