Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DiagnosticSource integration disabled incorrectly with TracesSampler #2039

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Fix DiagnosticSource integration disabled incorrectly with TracesSampler #2039

merged 4 commits into from
Nov 10, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Nov 9, 2022 •
edited
Loading

Fixes #2038

Also removed some dead code and updated tests.

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) November 9, 2022 20:38
@mattjohnsonpint mattjohnsonpint merged commit b8e01bf into main Nov 10, 2022
@mattjohnsonpint mattjohnsonpint deleted the fix-disabled-diagsource branch November 10, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DiagnosticSource Integration disabled incorrectly when using a TracesSampler
2 participants
@mattjohnsonpint @bitsandfoxes