DiagnosticSource Integration disabled incorrectly when using a TracesSampler

[mattjohnsonpint]

Package

Sentry

SDK Version

3.23.1

Steps to Reproduce

Set a TracesSampler that returns 1.0, without setting TracesSampleRate.

Expected Result

Since the TracesSampler prevails, database transactions should be instrumented.

Actual Result

Notice in the logs:

DiagnosticSource Integration is now disabled due to TracesSampleRate being set to zero.

Database transactions are not instrumented at all, because the integration is disabled.

[mattjohnsonpint]

Caused here:

sentry-dotnet/src/Sentry.DiagnosticSource/Internal/DiagnosticSource/SentryDiagnosticListenerIntegration.cs

Lines 14 to 19 in 6af8ce3

	if (options.TracesSampleRate == 0)
	{
	options.Log(SentryLevel.Info, "DiagnosticSource Integration is now disabled due to TracesSampleRate being set to zero.");
	options.DisableDiagnosticSourceIntegration();
	return;
	}

This should only be done if the TracesSampleRate is 0 and the TracesSampler option is null.