Fix: Checks in some tests broken #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dont swallow exceptions in user provided callbacks if enabled
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 52 52
Lines 1695 1695
=======================================
Hits 1537 1537
Misses 158 158 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@denrase should this target |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ae02632 | 309.16 ms | 348.98 ms | 39.82 ms |
| 5112c69 | 333.67 ms | 363.74 ms | 30.08 ms |
| 72dfc83 | 298.62 ms | 340.14 ms | 41.52 ms |
| 633cf2e | 289.36 ms | 340.38 ms | 51.02 ms |
| a1a1545 | 295.21 ms | 351.16 ms | 55.95 ms |
| 8d64376 | 302.88 ms | 356.84 ms | 53.96 ms |
| c1bb00f | 303.77 ms | 371.88 ms | 68.11 ms |
| fbf42af | 323.04 ms | 365.09 ms | 42.04 ms |
| aed5947 | 295.70 ms | 348.18 ms | 52.48 ms |
| 2331d89 | 352.45 ms | 417.34 ms | 64.89 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ae02632 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 5112c69 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 72dfc83 | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
| 633cf2e | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
| a1a1545 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 8d64376 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| c1bb00f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| fbf42af | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| aed5947 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 2331d89 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
Previous results on branch: fix/checks-in-some-tests-broken
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a184cd9 | 319.56 ms | 382.06 ms | 62.50 ms |
| 5550eae | 380.15 ms | 470.30 ms | 90.15 ms |
| 7aff6ac | 321.67 ms | 384.44 ms | 62.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a184cd9 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 5550eae | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 7aff6ac | 6.06 MiB | 7.10 MiB | 1.04 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
| a49594a | 1284.83 ms | 1313.29 ms | 28.45 ms |
| b49bf00 | 1248.00 ms | 1260.35 ms | 12.35 ms |
| d7758e8 | 1271.69 ms | 1288.08 ms | 16.39 ms |
| 2f8f173 | 1280.61 ms | 1292.20 ms | 11.59 ms |
| ef2f368 | 1259.12 ms | 1277.04 ms | 17.92 ms |
| 21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
| af2d175 | 1280.37 ms | 1282.24 ms | 1.88 ms |
| aed5947 | 1268.67 ms | 1281.10 ms | 12.43 ms |
| 3a69405 | 1292.84 ms | 1303.96 ms | 11.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
| a49594a | 8.16 MiB | 9.16 MiB | 1.00 MiB |
| b49bf00 | 8.10 MiB | 9.08 MiB | 1004.36 KiB |
| d7758e8 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
| 2f8f173 | 8.15 MiB | 9.13 MiB | 1000.39 KiB |
| ef2f368 | 8.15 MiB | 9.10 MiB | 965.24 KiB |
| 21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
| af2d175 | 8.15 MiB | 9.12 MiB | 986.22 KiB |
| aed5947 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 3a69405 | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
Previous results on branch: fix/checks-in-some-tests-broken
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7aff6ac | 1241.43 ms | 1254.02 ms | 12.59 ms |
| 5550eae | 1284.43 ms | 1296.84 ms | 12.41 ms |
| a184cd9 | 1249.79 ms | 1274.80 ms | 25.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7aff6ac | 8.10 MiB | 9.14 MiB | 1.05 MiB |
| 5550eae | 8.10 MiB | 9.14 MiB | 1.05 MiB |
| a184cd9 | 8.10 MiB | 9.14 MiB | 1.05 MiB |
denrase
requested review from
marandaneto,
brustolin and
krystofwoldrich
as code owners
marandaneto
reviewed
Mar 14, 2023
marandaneto
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
@denrase thanks.
integration test is unhappy, can you check that before emerging it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
devModeflag on sentry options💡 Motivation and Context
Closes #1122
💚 How did you test it?
sentry_test.dart📝 Checklist
sendDefaultPiiis enabled