Fix: Checks in some tests broken (#1315)

Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> Co-authored-by: Manoel Aranda Neto <marandaneto@gmail.com>
getsentry · Mar 15, 2023 · 689d2fd · 689d2fd
1 parent 333903e
commit 689d2fd
Show file tree

Hide file tree

Showing 14 changed files with 250 additions and 96 deletions.
diff --git a/dart/lib/src/hub.dart b/dart/lib/src/hub.dart
@@ -273,6 +273,9 @@ class Hub {
           exception: exception,
           stackTrace: stackTrace,
         );
+        if (_options.devMode) {
+          rethrow;
+        }
       }
     }
     return scope;
@@ -367,6 +370,9 @@ class Hub {
           SentryLevel.error,
           "Error in the 'configureScope' callback, error: $err",
         );
+        if (_options.devMode) {
+          rethrow;
+        }
       }
     }
   }

diff --git a/dart/lib/src/scope.dart b/dart/lib/src/scope.dart
@@ -171,6 +171,9 @@ class Scope {
           exception: exception,
           stackTrace: stackTrace,
         );
+        if (_options.devMode) {
+          rethrow;
+        }
       }
     }
     if (processedBreadcrumb != null) {
@@ -329,6 +332,9 @@ class Scope {
           exception: exception,
           stackTrace: stackTrace,
         );
+        if (_options.devMode) {
+          rethrow;
+        }
       }
       if (processedEvent == null) {
         _options.logger(SentryLevel.debug, 'Event was dropped by a processor');

diff --git a/dart/lib/src/sentry.dart b/dart/lib/src/sentry.dart
@@ -43,6 +43,7 @@ class Sentry {
     @internal SentryOptions? options,
   }) async {
     final sentryOptions = options ?? SentryOptions();
+
     await _initDefaultValues(sentryOptions);
 
     try {
@@ -57,6 +58,9 @@ class Sentry {
         exception: exception,
         stackTrace: stackTrace,
       );
+      if (sentryOptions.devMode) {
+        rethrow;
+      }
     }
 
     if (sentryOptions.dsn == null) {

diff --git a/dart/lib/src/sentry_client.dart b/dart/lib/src/sentry_client.dart
@@ -395,6 +395,9 @@ class SentryClient {
         exception: exception,
         stackTrace: stackTrace,
       );
+      if (_options.devMode) {
+        rethrow;
+      }
     }
 
     if (eventOrTransaction == null) {
@@ -429,6 +432,9 @@ class SentryClient {
           exception: exception,
           stackTrace: stackTrace,
         );
+        if (_options.devMode) {
+          rethrow;
+        }
       }
       if (processedEvent == null) {
         _recordLostEvent(event, DiscardReason.eventProcessor);

diff --git a/dart/lib/src/sentry_options.dart b/dart/lib/src/sentry_options.dart
@@ -343,6 +343,11 @@ class SentryOptions {
     _extractorsByType[extractor.exceptionType] = extractor;
   }
 
+  /// Changed SDK behaviour when set to true:
+  /// - Rethrow exceptions that occur in user provided closures
+  @internal
+  bool devMode = false;
+
   SentryOptions({this.dsn, PlatformChecker? checker}) {
     if (checker != null) {
       platformChecker = checker;

diff --git a/dart/lib/src/sentry_traces_sampler.dart b/dart/lib/src/sentry_traces_sampler.dart
@@ -38,6 +38,9 @@ class SentryTracesSampler {
           exception: exception,
           stackTrace: stackTrace,
         );
+        if (_options.devMode) {
+          rethrow;
+        }
       }
     }
 

diff --git a/dart/test/environment_test.dart b/dart/test/environment_test.dart
@@ -23,6 +23,7 @@ void main() {
         release: 'release-9.8.7',
         dist: 'bar',
       );
+      options.devMode = true;
 
       await Sentry.init(
         (options) => options,
@@ -43,6 +44,7 @@ void main() {
         release: 'release-9.8.7',
         dist: 'bar',
       );
+      options.devMode = true;
 
       await Sentry.init(
         (options) => options,

diff --git a/dart/test/event_processor/deduplication_event_processor_test.dart b/dart/test/event_processor/deduplication_event_processor_test.dart
@@ -77,12 +77,14 @@ void main() {
 
       final transport = MockTransport();
 
+      final options = SentryOptions(dsn: fakeDsn)..devMode = true;
       await Sentry.init(
         (options) {
           options.dsn = fakeDsn;
           options.transport = transport;
           options.enableDeduplication = true;
         },
+        options: options,
       );
 
       // The test doesn't work if `outerTestMethod` is passed as

diff --git a/dart/test/event_processor/enricher/io_enricher_test.dart b/dart/test/event_processor/enricher/io_enricher_test.dart
@@ -159,16 +159,18 @@ void main() {
     });
 
     test('$IoEnricherEventProcessor gets added on init', () async {
-      late SentryOptions sentryOptions;
+      final options = SentryOptions(dsn: fakeDsn)..devMode = true;
+      late SentryOptions configuredOptions;
       await Sentry.init(
         (options) {
           options.dsn = fakeDsn;
-          sentryOptions = options;
+          configuredOptions = options;
         },
+        options: options,
       );
       await Sentry.close();
 
-      final ioEnricherCount = sentryOptions.eventProcessors
+      final ioEnricherCount = configuredOptions.eventProcessors
           .whereType<IoEnricherEventProcessor>()
           .length;
       expect(ioEnricherCount, 1);

diff --git a/dart/test/initialization_test.dart b/dart/test/initialization_test.dart
@@ -14,28 +14,42 @@ void main() {
   });
 
   test('async re-initilization', () async {
-    await Sentry.init((options) {
-      options.dsn = fakeDsn;
-    });
+    final options = SentryOptions(dsn: fakeDsn)..devMode = true;
+    await Sentry.init(
+      (options) {
+        options.dsn = fakeDsn;
+      },
+      options: options,
+    );
 
     await Sentry.close();
 
-    await Sentry.init((options) {
-      options.dsn = fakeDsn;
-    });
+    await Sentry.init(
+      (options) {
+        options.dsn = fakeDsn;
+      },
+      options: options,
+    );
   });
 
   // This is the failure from
   // https://github.com/getsentry/sentry-dart/issues/508
   test('re-initilization', () async {
-    await Sentry.init((options) {
-      options.dsn = fakeDsn;
-    });
+    final options = SentryOptions(dsn: fakeDsn)..devMode = true;
+    await Sentry.init(
+      (options) {
+        options.dsn = fakeDsn;
+      },
+      options: options,
+    );
 
     await Sentry.close();
 
-    await Sentry.init((options) {
-      options.dsn = fakeDsn;
-    });
+    await Sentry.init(
+      (options) {
+        options.dsn = fakeDsn;
+      },
+      options: options,
+    );
   });
 }