Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add shared samples assets #4461

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

philipphofmann
Copy link
Member

Remove duplicated AppIcon assets by using one shared samples assets.

#skip-changelog

Remove duplicated AppIcon assets by using one shared samples assets.
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect. Thanks!!

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.67 ms 1239.08 ms 25.41 ms
Size 21.90 KiB 708.33 KiB 686.43 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4350d44 1228.75 ms 1246.75 ms 18.00 ms
0559a8f 1239.78 ms 1252.60 ms 12.83 ms
4bca912 1252.42 ms 1260.06 ms 7.64 ms
bb7da60 1231.80 ms 1252.65 ms 20.85 ms
53a8885 1241.02 ms 1270.66 ms 29.64 ms
94d8eb3 1221.56 ms 1236.81 ms 15.26 ms
7e8d5fd 6249.23 ms 6253.90 ms 4.67 ms
b048ba3 1215.32 ms 1234.61 ms 19.29 ms
c9724f9 1199.38 ms 1229.54 ms 30.16 ms
b2e7962 1234.70 ms 1241.98 ms 7.28 ms

App size

Revision Plain With Sentry Diff
4350d44 21.58 KiB 629.82 KiB 608.24 KiB
0559a8f 21.58 KiB 419.81 KiB 398.23 KiB
4bca912 22.85 KiB 411.14 KiB 388.29 KiB
bb7da60 21.58 KiB 697.84 KiB 676.25 KiB
53a8885 20.76 KiB 434.65 KiB 413.89 KiB
94d8eb3 21.58 KiB 417.86 KiB 396.28 KiB
7e8d5fd 20.76 KiB 435.50 KiB 414.74 KiB
b048ba3 21.90 KiB 707.64 KiB 685.74 KiB
c9724f9 20.76 KiB 427.66 KiB 406.90 KiB
b2e7962 21.58 KiB 670.39 KiB 648.81 KiB

@philipphofmann philipphofmann merged commit 750f4d7 into main Oct 22, 2024
51 checks passed
@philipphofmann philipphofmann deleted the test/add-shared-sample-assets branch October 22, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants