Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add macOS SwiftUI sample app #4459

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Conversation

philipphofmann
Copy link
Member

Add a sample app for macOS with SwiftUI using the
NSApplicationDelegateAdaptor.

This is required because a customer has this setup and would like to make uncaught NSExceptions work correctly. With this sample app, we can test their setup.

#skip-changelog

Add a sample app for macOS with SwiftUI using the
NSApplicationDelegateAdaptor.
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, I would prefer to have less assets (in this case the icons).
With cocoapod or SPM, our users download all the samples too, the less bits the better.

@philipphofmann
Copy link
Member Author

Just one suggestion, I would prefer to have less assets (in this case the icons). With cocoapod or SPM, our users download all the samples too the less bits the better.

Excellent point. I will update the PR after merging this one: #4461.

@philipphofmann philipphofmann merged commit 2d0e628 into main Oct 24, 2024
37 checks passed
@philipphofmann philipphofmann deleted the test/add-macos-swift-ui branch October 24, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants