Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentrycrashdl_getBinaryImageForHeader causes AppHangs #4399

Closed
philipphofmann opened this issue Oct 3, 2024 · 0 comments · Fixed by #4435
Closed

sentrycrashdl_getBinaryImageForHeader causes AppHangs #4399

philipphofmann opened this issue Oct 3, 2024 · 0 comments · Fixed by #4435
Assignees
@philipphofmann
Labels
Platform: Cocoa Type: Bug

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Oct 3, 2024 •
edited
Loading

Description

A customer reported around 10k app hangs pointing to sentrycrashdl_getBinaryImageForHeader when being called from the SentryTracer.

sentrycrashdl_getBinaryImageForHeader
-[SentryDebugImageProvider getDebugImagesCrashed:]
-[SentryDebugImageProvider getDebugImagesCrashed:]
-[SentryDebugImageProvider getDebugImagesForAddresses:isCrash:]
-[SentryDebugImageProvider getDebugImagesForFrames:isCrash:]
-[SentryTracer toTransaction]
-[SentryTracer finishInternal]
@philipphofmann philipphofmann self-assigned this Oct 9, 2024
@philipphofmann philipphofmann mentioned this issue Oct 10, 2024
Closed
7 tasks
philipphofmann added a commit that referenced this issue Oct 14, 2024
@philipphofmann
impr: Speed up getBinaryImages
edb149c 
Add two new internal methods getDebugImagesFromCacheForFrames
getDebugImagesFromCacheFrames to the SentryDebugImageProvider which use
the significantly faster SentryBinaryImageCache.

Fixes GH-4399
This was referenced Oct 14, 2024
Merged
Open
Open
philipphofmann added a commit that referenced this issue Oct 14, 2024
@philipphofmann
impr: Speed up getBinaryImages (#4435)
a2cf26e 
Add two new internal methods getDebugImagesFromCacheForFrames
getDebugImagesFromCacheFrames to the SentryDebugImageProvider which use
the significantly faster SentryBinaryImageCache.

Fixes GH-4399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
Platform: Cocoa Type: Bug
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

impr: Speed up getBinaryImages getsentry/sentry-cocoa
1 participant
@philipphofmann