-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cached methods SentryDebugImageProvider of the Cocoa SDK #4169
Comments
Hey @philipphofmann, @krystofwoldrich 👋
I can open a PR on |
Yes, let's add getDebugImagesForImageAddressesFromCache to the hybrid SDKs header. |
Opened getsentry/sentry-cocoa#4460 and I plan to update my RN PR that currently uses the private method as soon as the next sentry-cocoa version is released. |
Description
Replace
sentry-react-native/ios/RNSentry.mm
Line 323 in a371274
with either
SentryDebugImageProvider.getDebugImagesFromCacheForFrames
orSentryDebugImageProvider.getDebugImagesFromCacheForThreads
added in getsentry/sentry-cocoa#4435, which will most likely ship with Cocoa 8.39.0.getDebugImagesForAddresses
is slow and caused AppHangs on iOS; see getsentry/sentry-cocoa#4399.The text was updated successfully, but these errors were encountered: