Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Explicitly close kafka consumer #452

Merged
merged 2 commits into from
Feb 4, 2020
Merged

fix(test): Explicitly close kafka consumer #452

merged 2 commits into from
Feb 4, 2020

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Feb 4, 2020 •
edited
Loading

We have no idea whether xdist actually forks before importing modules or after, or whether rdkafka is fork-safe. Let's just take the safe route.

confluentinc/confluent-kafka-python#265

@untitaker untitaker requested a review from a team February 4, 2020 12:27
@untitaker untitaker changed the title fix: Avoid some potential pitfalls wrt fork-safety in kafka fix: Explicitly close kafka consumer Feb 4, 2020
@jan-auer jan-auer changed the title fix: Explicitly close kafka consumer fix(test): Explicitly close kafka consumer Feb 4, 2020
@jan-auer jan-auer merged commit 3c181d2 into master Feb 4, 2020
@jan-auer jan-auer deleted the fix/fork-safety branch February 4, 2020 15:14
jan-auer added a commit that referenced this pull request Feb 4, 2020
@jan-auer
Merge branch 'master' into feature/sessions
a6e6980 
* master:
  fix(test): Explicitly close kafka consumer (#452)
  fix: Set sent_at in RequestMeta::merge (#447)
  doc: Document pii selectors (#451)
  feat(server): Limit maximum rate limits in processing (#450)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @jan-auer