fix(test): Explicitly close kafka consumer (#452)

getsentry · Feb 4, 2020 · 3c181d2 · 3c181d2
1 parent 4e2a06b
commit 3c181d2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/integration-test-requirements.txt b/integration-test-requirements.txt
@@ -2,9 +2,10 @@ pytest
 pytest-localserver
 requests
 flask
+werkzeug==0.15.1
 confluent-kafka
 msgpack
 pytest-rerunfailures
-pytest-xdist
-redis
+pytest-xdist==1.31.0
+redis==3.4.1
 git+https://github.com/untitaker/pytest-sentry#egg=pytest-sentry
diff --git a/tests/integration/fixtures/processing.py b/tests/integration/fixtures/processing.py
@@ -125,7 +125,12 @@ def inner(topic: str, options=None):
 
         consumer = kafka.Consumer(settings)
         consumer.subscribe(topics)
-        request.addfinalizer(consumer.unsubscribe)
+
+        def die():
+            consumer.unsubscribe()
+            consumer.close()
+
+        request.addfinalizer(die)
 
         while consumer.poll(timeout=0.1) is not None:
             pass