Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Make status codes consistent with Sentry #365

Merged
merged 2 commits into from
Dec 12, 2019

Conversation

jan-auer
Copy link
Member

This should restore the 401 and 403 status codes as in Sentry.

@jan-auer jan-auer requested review from untitaker and tonyo December 12, 2019 02:35
@jan-auer jan-auer self-assigned this Dec 12, 2019
@jan-auer
Copy link
Member Author

Please review carefully and compare with Sentry's web/api.py and coreapi.py. There are a few cases that we no longer map in Relay, however.

Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine now

@jan-auer
Copy link
Member Author

@untitaker thanks!

@jan-auer jan-auer merged commit cad23b3 into master Dec 12, 2019
@jan-auer jan-auer deleted the fix/status-codes branch December 12, 2019 16:47
jan-auer added a commit that referenced this pull request Dec 17, 2019
* master:
  fix: Update fixture to produce stable snapshot
  fix: Check in missing snapshot
  ref: Bump sentry-types
  test(general): Add a snapshot for Android
  Revert "feat(general): Add thread.errored attribute (#306)" (#366)
  Revert "doc: Changelog for 0.4.66"
  doc: Changelog for 0.4.66
  fix(server): Make status codes consistent with Sentry (#365)
  release: 0.4.65
  test: Update security report test snapshots
  build: Update redis dependency
  meta: Changelog for 0.4.65
  Revert "ref: Use jemalloc instead of system allocator (#344)" (#360)
  ref: Update user-agent database (#363)
  build: Update rdkafka to replace git dependency (#364)
jan-auer added a commit that referenced this pull request Dec 18, 2019
* master:
  fix(server): Preserve event id of minidump upload (#361)
  fix: Update fixture to produce stable snapshot
  fix: Check in missing snapshot
  ref: Bump sentry-types
  test(general): Add a snapshot for Android
  Revert "feat(general): Add thread.errored attribute (#306)" (#366)
  Revert "doc: Changelog for 0.4.66"
  doc: Changelog for 0.4.66
  fix(server): Make status codes consistent with Sentry (#365)
  release: 0.4.65
  test: Update security report test snapshots
  build: Update redis dependency
  meta: Changelog for 0.4.65
  Revert "ref: Use jemalloc instead of system allocator (#344)" (#360)
  ref: Update user-agent database (#363)
  build: Update rdkafka to replace git dependency (#364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants