ref: Use jemalloc instead of system allocator #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Nov 29, 2019
mitsuhiko
approved these changes
Nov 29, 2019
jan-auer
reviewed
Nov 29, 2019
|
@jan-auer I benched locally and could not see any difference at all. My suspicion is that this will have a positive impact on memory fragmentation at best. |
|
If there was no measurable difference, why were we merging this then? |
|
Because I tested rps, nothing else. That gives me some confidence that it
does not break or heavily regress semaphore in perf, but it is yet to be
seen if it maybe improves memory usage of long running instances.
…On Sun, Dec 1, 2019, 00:09 Jan Michael Auer ***@***.***> wrote:
If there was no measurable difference, why were we merging this then?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#344>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGMPRM7UO622NCZVV45R3DQWLXAXANCNFSM4JTAN7EQ>
.
|
untitaker
added a commit
that referenced
this pull request
Dec 11, 2019
This reverts commit 4eafc47.
jan-auer
pushed a commit
that referenced
this pull request
Dec 11, 2019
jan-auer
added a commit
that referenced
this pull request
Dec 17, 2019
* master: fix: Update fixture to produce stable snapshot fix: Check in missing snapshot ref: Bump sentry-types test(general): Add a snapshot for Android Revert "feat(general): Add thread.errored attribute (#306)" (#366) Revert "doc: Changelog for 0.4.66" doc: Changelog for 0.4.66 fix(server): Make status codes consistent with Sentry (#365) release: 0.4.65 test: Update security report test snapshots build: Update redis dependency meta: Changelog for 0.4.65 Revert "ref: Use jemalloc instead of system allocator (#344)" (#360) ref: Update user-agent database (#363) build: Update rdkafka to replace git dependency (#364)
jan-auer
added a commit
that referenced
this pull request
Dec 18, 2019
* master: fix(server): Preserve event id of minidump upload (#361) fix: Update fixture to produce stable snapshot fix: Check in missing snapshot ref: Bump sentry-types test(general): Add a snapshot for Android Revert "feat(general): Add thread.errored attribute (#306)" (#366) Revert "doc: Changelog for 0.4.66" doc: Changelog for 0.4.66 fix(server): Make status codes consistent with Sentry (#365) release: 0.4.65 test: Update security report test snapshots build: Update redis dependency meta: Changelog for 0.4.65 Revert "ref: Use jemalloc instead of system allocator (#344)" (#360) ref: Update user-agent database (#363) build: Update rdkafka to replace git dependency (#364)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope that this will improve memory usage