-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update cli version #186
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,9 +25,7 @@ RUN export YARN_CACHE_FOLDER="$(mktemp -d)" \ | |
COPY --from=builder /app/dist /action-release/dist/ | ||
RUN chmod +x /action-release/dist/index.js | ||
|
||
# move the sentry-cli binary to where the entrypoint expects it | ||
RUN mv /action-release/node_modules/@sentry/cli/sentry-cli /action-release/sentry-cli | ||
RUN chmod +x /action-release/sentry-cli | ||
RUN printf '[safe]\n directory = *\n' > /etc/gitconfig | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure how hacky this is or if it will cause problems on other binaries since each OS can have different implementations There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's in a docker container so the os is fixed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @asottile-sentry Oh yea duh...brain is slow after the holidays |
||
|
||
# XXX: This could probably be replaced with a standard CMD | ||
COPY entrypoint.sh /entrypoint.sh | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this hack anymore :D