feat: update cli version #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scefali
commented
Jan 8, 2024
| @@ -25,9 +25,7 @@ RUN export YARN_CACHE_FOLDER="$(mktemp -d)" \ | |||
| COPY --from=builder /app/dist /action-release/dist/ | |||
| RUN chmod +x /action-release/dist/index.js | |||
|
|
|||
| # move the sentry-cli binary to where the entrypoint expects it | |||
| RUN mv /action-release/node_modules/@sentry/cli/sentry-cli /action-release/sentry-cli | |||
There was a problem hiding this comment.
Don't need this hack anymore :D
scefali
commented
Jan 8, 2024
| # move the sentry-cli binary to where the entrypoint expects it | ||
| RUN mv /action-release/node_modules/@sentry/cli/sentry-cli /action-release/sentry-cli | ||
| RUN chmod +x /action-release/sentry-cli | ||
| RUN printf '[safe]\n directory = *\n' > /etc/gitconfig |
There was a problem hiding this comment.
Not sure how hacky this is or if it will cause problems on other binaries since each OS can have different implementations
There was a problem hiding this comment.
it's in a docker container so the os is fixed
There was a problem hiding this comment.
@asottile-sentry Oh yea duh...brain is slow after the holidays
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the CLI to the latest version (2.24.1).