Fix param added with empty query ignores options #4736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This one was a bit hard to find 😅. From what I understood on this code:
redash/client/app/services/query.js
Lines 226 to 235 in a682265
It exists to determine when to skip parameters sync (query text with actual parameters list in query object). Since parameters are added in a context of inequality between the cachedQuery and the query text, the idea is to keep those parameters in there until the query text is modified (what wasn't happening for an empty query text)
Related Tickets & Documents
Fixes #4723
and #4146 is the one that triggered this context to be possible
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--