Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove core-js and polyfill include as we don't use Phantom anymore #4583

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Remove core-js and polyfill include as we don't use Phantom anymore #4583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9afe660
Remove core-js and polyfill include as we don't use Phantom anymore
arikfr Jan 23, 2020
2d6b6f7
Merge branch 'master' into remove-core-js
arikfr Feb 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions client/app/config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
// This polyfill is needed to support PhantomJS which we use to generate PNGs from embeds.
import "core-js/fn/typed/array-buffer";

import moment from "moment";
import * as Pace from "pace-progress";
import { isFunction } from "lodash";
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"brace": "^0.11.0",
"chroma-js": "^1.3.6",
"classnames": "^2.2.6",
"core-js": "^2.6.4",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kravets-levko I was expecting it to update package-lock.json but it didn't. Do you know why?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because some other dependency still use it. You can try to search for core-js in package-lock.json to check this. I guess Babel may need CoreJS, maybe some other libs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought too, but then I expected it to pick up a newer versions. Oh, well 🤷‍♂️

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get a newer version you have to run npm install again; npm uninstall just removes packages and does not update others.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just edited package.json 🤠 But I did run npm install afterwards.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked package-lock.json - Babel and React have core-js among their dependencies (React has it through fbjs dependency)

"d3": "^3.5.17",
"d3-cloud": "^1.2.4",
"debug": "^3.1.0",
Expand Down