Remove core-js and polyfill include as we don't use Phantom anymore #4583
Conversation
| @@ -47,7 +47,6 @@ | |||
| "brace": "^0.11.0", | |||
| "chroma-js": "^1.3.6", | |||
| "classnames": "^2.2.6", | |||
| "core-js": "^2.6.4", | |||
There was a problem hiding this comment.
@kravets-levko I was expecting it to update package-lock.json but it didn't. Do you know why?
There was a problem hiding this comment.
Probably because some other dependency still use it. You can try to search for core-js in package-lock.json to check this. I guess Babel may need CoreJS, maybe some other libs.
There was a problem hiding this comment.
That's what I thought too, but then I expected it to pick up a newer versions. Oh, well 🤷♂️
There was a problem hiding this comment.
To get a newer version you have to run npm install again; npm uninstall just removes packages and does not update others.
There was a problem hiding this comment.
I actually just edited package.json 🤠 But I did run npm install afterwards.
There was a problem hiding this comment.
I checked package-lock.json - Babel and React have core-js among their dependencies (React has it through fbjs dependency)
What type of PR is this? (check all applicable)
Description
We switched to Puppeteer a long ago, so this is no longer relevant.