Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep query result pagination out of scroll #2584

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

alison985
Copy link
Contributor

fixes #2581

The query result pagination was already in a separate div, I just had to force the scroll into the query results and out of the entire dynamic-table tag.

@kravets-levko
Copy link
Collaborator

hi @alison985! does it also work well with dashboard widgets? did you check it?

@alison985
Copy link
Contributor Author

@kravets-levko This is working for me on dashboard widgets as well.

@alison985
Copy link
Contributor Author

@arikfr, this was approved by @kravets-levko and relates to PR #2570.

@arikfr arikfr merged commit b1139d4 into getredash:master Jul 16, 2018
@arikfr
Copy link
Member

arikfr commented Jul 16, 2018

🕺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page navigation should not be included in the query results table
3 participants