Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes query pagination alignment #2570

Merged

Conversation

alison985
Copy link
Contributor

fixes #2569

Same as mozilla#413 which fixes mozilla#320

@arikfr
Copy link
Member

arikfr commented Jun 6, 2018

I'm not sure about this one actually. Because the pagination is in the same "container" element as the table itself, if the table is wide enough, it might make the pagination not visible without scrolling.

Maybe the paginator needs its own container (which is 100% width of the parent), and then we can center it?

@kocsmy wdyt?

@kocsmy
Copy link
Collaborator

kocsmy commented Jun 11, 2018

I'm not sure either about the center position. The table can be very wide + the left alignment kinda makes sense here for me.

If you implement this, make sure it gets its own container as @arikfr was suggesting.

@alison985
Copy link
Contributor Author

This is related to #2584.

@arikfr arikfr merged commit 2ff3d89 into getredash:master Jul 16, 2018
@arikfr
Copy link
Member

arikfr commented Jul 16, 2018

Thanks!

@arikfr arikfr mentioned this pull request Jul 26, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants