Add ability to easily select all for multi-filter #1946
Merged
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multi filter option is useful but lacking in an easy easy way to select all values. I have added in a psudo option '*' that when selected automatically fills out the mutli-select with all possible filters. I have also added in a second psudo option '-' which becomes available _if_ the multi-filter has all possible values selected. This makes it easy to clear the multi-filter.
|
I updated the file client/app/services/query-result.js and I cannot see the option "*" or "-" in the multi filter. |
|
@dimar7 how did you update query-result? are you using the webpack dev server or did you recompile the frontend |
|
yes I did update query result. How can I reccompile the front end? I'm not familiar with webpack dev server, |
|
How call I the filter using your code? |
|
👏 well done. You made a lot of people happy now :) |
|
can anyone say me how can I set de filter with '*' or '-'? |
|
+1 Would also like to know how I can add this functionality to the AMI Amazon build! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in direct response for Issue 608
The multi filter option is useful, but lacking in an easy way to
select all values. I have added in a psudo option '*' that when selected
automatically fills out the mutli-select with all possible filters.
I have also added in a second psudo option '-' which becomes available
if the multi-filter has all possible values selected.
This makes it easy to clear the multi-filter.
As far as I can tell there are no tests for the front end client.
I will add them if you can point me in the right spot of the codebase.