Regression using * in ::multi-filter fields

[kewisch]

Issue Summary

Since the recent STMO deployment, queries using the * trick for ::multi-filters no longer display the right results. See this upstream PR for details, it is unfortunately not well documented.

Steps to Reproduce

1. Run this query and notice it has results and works fine
2. Run this other query which is the same but adds a result row with * in the ::multi-filter fields which should conveniently select all values in the ::multi-filter

Results

• Query 2 only has one row with the * in it, the other results are missing.
• The ::multi-filters are not pre-populated with the values, only *.

Expected

• All rows from the query result are shown.
• The row with * is not shown as a result, but pre-populates the ::multi-filters as before

[washort]

This behavior was an unintentional "feature" and has gone away due to upstream rewriting the filter UI to be a react component. (This is arguably a bug if any of the values to be filtered on are *.)

A proper fix for this might be to add a toggle in the chart-editing UI to make filters default to all values instead of none.

[kewisch]

See getredash#3905 for a WiP upstream PR, I'll file an actual issue a bit later.