Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A user that is granted permissions to a dashboard cannot grant permissions to others for the dashboard #2592

Closed
alison985 opened this issue Jun 17, 2018 · 0 comments · Fixed by #2650
Closed

A user that is granted permissions to a dashboard cannot grant permissions to others for the dashboard #2592

alison985 opened this issue Jun 17, 2018 · 0 comments · Fixed by #2650

Comments

@alison985
Copy link
Contributor

Copies mozilla#346

Making an issue to submit a PR against.
alison985 added a commit to StantonVentures/redash that referenced this issue Jun 30, 2018
@alison985
add error message when non owner tries to add a user to a dashboard
729614b 
fixes getredash#2592

REDASH_FEATURE_SHOW_PERMISSIONS_CONTROL has to equal true for this to be applicable.

Operation does throw a 403 Forbidden error before this change but it is in the console not shown to the user.
@alison985 alison985 mentioned this issue Jun 30, 2018
Merged
jezdez pushed a commit that referenced this issue Aug 23, 2018
@alison985 @jezdez
Throw error when non-owner tries to add a user to dashboard permissio…
82af372 
…ns (#2650)

Add error message when non owner tries to add a user to a dashboard

Fixes #2592

REDASH_FEATURE_SHOW_PERMISSIONS_CONTROL has to be true for this to be applicable.

Operation threw a 403 Forbidden error before this change but it is in the console not shown to the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw error when non-owner tries to add a user to dashboard permissions StantonVentures/redash
1 participant
@alison985