Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A user that is granted permissions to a dashboard cannot grant permissions to others for the dashboard #346

Closed
emtwo opened this issue Feb 28, 2018 · 5 comments

Comments

@emtwo
Copy link

emtwo commented Feb 28, 2018

STR:

  1. Create a new dashboard
  2. Give another person permission for the dashboard
  3. The other person tries to give permission to a third person

Actual result: Silent failure. The user seems to be in the list but they don't have permissions to edit

Expected result: The permissions should either be added or an error is given that explains "permission denied"

@alison985
Copy link

@emtwo How do you grant a user permissions to edit a dashboard? I am not seeing anything in the menus of a dashboard.

@alison985 alison985 self-assigned this Jun 17, 2018
@jezdez
Copy link

jezdez commented Jun 19, 2018

@alison985 This is how it looks like if I create a dashboard on stage:

screen-shot-2018-06-19-20-45-14

I wonder if this is a permission issue for you?

Looking at the code it uses showPermissionsControl which ends up being set in the Redash settings system via the environment variable REDASH_FEATURE_SHOW_PERMISSIONS_CONTROL and it defaults to false. Seems like this was enabled in stage/prod and you'll need to enable it locally, too.

@alison985
Copy link

Yep, that configuration setting allowed me to see "Manage Permissions" in the menu.

This is reproducible against upstream master. Submitted PR against upstream: getredash#2650

@alison985 alison985 added the in review upstream PR in review in getredash/redash label Jul 8, 2018
@rafrombrc rafrombrc modified the milestones: 15, 16 Jul 11, 2018
@rafrombrc rafrombrc modified the milestones: 16, 17 Aug 9, 2018
@jezdez
Copy link

jezdez commented Aug 23, 2018

Merged upstream! ✨

@jezdez jezdez closed this as completed Aug 23, 2018
@jezdez jezdez added merge upstream and removed in review in review upstream PR in review in getredash/redash labels Aug 23, 2018
@vcarciu
Copy link

vcarciu commented Sep 7, 2018

Verified as fixed. An error explaining the permission denied is displayed:
permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants