-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install a bundle with duffle #233
Conversation
f37f81d
to
ac6d0b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naturally, this is still in draft, so just giving it a quick looksee and it all is looking good to me 👍
901f77f
to
a69979b
Compare
I've rebased to include the other merged pull requests and addressed your feedback. Onwards towards victory, claims and credentials! 💨 |
Lifted from duffle and will need to be exported
Ok, claims and credentials are in place and this is ready for review @vdice. After this is merged, I'll submit a PR to duffle to export the functions that I copied. It was a bit more complicated that just copying because I needed to change the duffle "home" so I want to get this in first, and then work with the duffle maintainers on how to best expose these functions as a library, where duffle is an instance that was created with a specific home given to it, instead of always reading from the environment variable (essentially a global). |
@vdice I ended up making a change to the command structure. The claim name is now an optional positional argument instead of a flag. $ ./bin/porter install --help
Install a bundle.
The first argument is the name of the claim to create for the installation. The claim name defaults to the name of the bundle.
Usage:
porter install [CLAIM] [flags]
Examples:
porter install
porter install --insecure
porter install MyAppInDev --file myapp/bundle.json I started working on |
This is using two other PRs #232 and #229.