Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install a bundle with duffle #233

Merged
merged 8 commits into from
Mar 27, 2019
Merged

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Mar 25, 2019

  • Install hello world
  • Parameters
  • Credentials
  • Store the claim
  • Install wordpress

This is using two other PRs #232 and #229.

@ghost ghost assigned carolynvs Mar 25, 2019
@ghost ghost added the review label Mar 25, 2019
@carolynvs carolynvs force-pushed the install-w-duffle branch 2 times, most recently from f37f81d to ac6d0b3 Compare March 25, 2019 18:50
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naturally, this is still in draft, so just giving it a quick looksee and it all is looking good to me 👍

pkg/cnab/provider/bundle.go Show resolved Hide resolved
scripts/test/test-wordpress.sh Outdated Show resolved Hide resolved
@carolynvs
Copy link
Member Author

I've rebased to include the other merged pull requests and addressed your feedback. Onwards towards victory, claims and credentials! 💨

@carolynvs carolynvs marked this pull request as ready for review March 26, 2019 14:41
@carolynvs
Copy link
Member Author

Ok, claims and credentials are in place and this is ready for review @vdice.

After this is merged, I'll submit a PR to duffle to export the functions that I copied. It was a bit more complicated that just copying because I needed to change the duffle "home" so I want to get this in first, and then work with the duffle maintainers on how to best expose these functions as a library, where duffle is an instance that was created with a specific home given to it, instead of always reading from the environment variable (essentially a global).

@carolynvs
Copy link
Member Author

@vdice I ended up making a change to the command structure. The claim name is now an optional positional argument instead of a flag.

$ ./bin/porter install --help
Install a bundle.

The first argument is the name of the claim to create for the installation. The claim name defaults to the name of the bundle.

Usage:
  porter install [CLAIM] [flags]

Examples:
  porter install
  porter install --insecure
  porter install MyAppInDev --file myapp/bundle.json

I started working on porter uninstall and I wanted it to look like porter uninstall mydb or whatever, and wanted symmetry between the commands.

@carolynvs carolynvs merged commit db2e482 into getporter:master Mar 27, 2019
@ghost ghost removed the review label Mar 27, 2019
@carolynvs carolynvs deleted the install-w-duffle branch March 27, 2019 16:17
@carolynvs carolynvs mentioned this pull request Mar 28, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants