Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add porter install command #229

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Add porter install command #229

merged 3 commits into from
Mar 25, 2019

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Mar 18, 2019

This is the skeleton for the install command.

$ porter bundle install --help
Install a bundle

Usage:
  porter install [flags]

Examples:
  porter install
  porter install --insecure
  porter install --file myapp/bundle.json
  porter install --name MyAppInDev
  porter install --param-file base-values.txt --param-file dev-values.txt --param test-mode=true --param header-color=blue
  porter install --cred azure --cred kubernetes


Flags:
  -c, --cred strings         Credential to use when installing the bundle. May be either a named set of credentials or a filepath.
  -f, --file string          Path to the CNAB definition to install (default "bundle.json")
  -h, --help                 help for install
      --insecure             Allow installing untrusted bundles
      --name string          Name of the claim, defaults to the name of the bundle
      --param strings        Define an individual parameter in the form NAME=VALUE. Overrides parameters set with the same name using --param-file. May be specified multiple times.
      --param-file strings   Path to a parameters definition file for the bundle, each line in the form of NAME=VALUE. May be specified multiple times.

Part of #106.

@ghost ghost assigned carolynvs Mar 18, 2019
@ghost ghost added the review label Mar 18, 2019
@carolynvs carolynvs mentioned this pull request Mar 19, 2019
5 tasks
@carolynvs carolynvs force-pushed the install branch 2 times, most recently from 9b5ff52 to 4a97bfc Compare March 19, 2019 22:03
@carolynvs carolynvs requested a review from jeremyrickard March 19, 2019 22:04
@carolynvs carolynvs marked this pull request as ready for review March 19, 2019 22:06
@carolynvs carolynvs mentioned this pull request Mar 25, 2019
5 tasks
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment around flag usage. Else, LGTM!

cmd/porter/bundle.go Outdated Show resolved Hide resolved
@carolynvs carolynvs merged commit ecc3bdd into getporter:master Mar 25, 2019
@ghost ghost removed the review label Mar 25, 2019
@carolynvs carolynvs deleted the install branch March 25, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants