Add tryParseJson utility method #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jigar-f
reviewed
Jul 4, 2024
| @@ -65,8 +65,10 @@ open class LanternHttpClient : HttpClient() { | |||
|
|
|||
| override fun onSuccess(response: Response?, result: JsonObject?) { | |||
| result?.let { | |||
| val user: ProUser = JsonUtil.fromJson<ProUser>(result.toString()) | |||
| cb.onSuccess(response!!, user) | |||
| val user: ProUser? = JsonUtil.tryParseJson<ProUser?>(result.toString()) | |||
There was a problem hiding this comment.
@atavism The only issue is here, while parsing JSON, if we get into any issue, I guess it will never return a response and even if it returns a response then it will return a null guess.
With an older approach, if we get into parsing issue, It will still parse some basic values and return results, so app does not crash.
There was a problem hiding this comment.
My thinking with this change is if the API suddenly behaves in some unexpected manner (returns null for some field when it previously always returned an empty array), we should treat that response as invalid and skip over it vs. trying to extract valid fields from it. With either approach, the app shouldn't crash now
atavism
added a commit
that referenced
this pull request
Jul 4, 2024
* Set default values on ProUser data class * Update checksum * use gradle 8.4.0 plugin for now * update sentry * use kotlinx.serialization * use kotlinx.serialization * updates to use kotlinx.serialization * Remove old ProPlan * clean-ups, update logging * Update checksum * Updated android-db and messages. * Added more error handling. * Add tryParseJson utility method (#1117) * Add tryParseJson utility method * formatting --------- Co-authored-by: Jigar-f <jigar@getlantern.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.