Set default values on ProUser data class

[atavism]

The changes from #1114 minus the db-android upgrade.

Resolves https://github.com/getlantern/engineering/issues/1476

[atavism]

@jigar-f I think we could put out a new release right away with this fix and then another release tomorrow with your change.. if that's okay with you?

[jigar-f]

@atavism Could you please just give me an hour, this issue is with purchase, let me look into it now.

[atavism]

@atavism Could you please just give me an hour, this issue is with purchase, let me look into it now.

Oh, sure. Thanks for taking a look!

[jigar-f]

@atavism I think you know better on this, So the issue is this events never gets a callback, It only gets callbacks when user install the app for the first time After that is never callback,

Due to that issue currency list never gets updated. So while purchasing it always sends USD, and this is an issue.

[jigar-f]

Do you mind taking a look at it, Since you work on these event flows, I tried to see what's going on, not able to find issue.

[atavism]

@atavism I think you know better on this, So the issue is this events never gets a callback, It only gets callbacks when user install the app for the first time After that is never callback,
Due to that issue currency list never gets updated. So while purchasing it always sends USD, and this is an issue.

Thanks for the information. I am just about done testing the changes here so I can look into this next

[atavism]

It turns out there was another issue: the GSON library that we are using "turns missing fields into null values": https://medium.com/@clay07g/gson-will-assign-missing-values-as-null-3f02f19f2145

"Obviously, this doesn’t use Kotlin’s default values. As far as I know, there isn’t a way to access them via reflection. Unfortunately, either way, the solution is very clunky."

I updated this PR to use kotlinx.serialization, and I confirmed the default values are being properly set now on ProUser:

07-03 12:06:04.045 14641 14882 D org.getlantern.lantern.model.LanternSessionManager:
Storing user data ProUser(userId=372784204, token=kI3.., referral=8YXPUN, email=, userStatus=,
code=8YXPUN, locale=en_US, subscription=, expiration=0, devices=[], userLevel=)

[atavism]

@jigar-f Ok, the changes to use kotlinx.serialization instead of GSON are working well for me. You can see in the logs that there are no nulls now for the different data types and the default values are preserved

07-03 14:02:57.383 26562 26812 D org.getlantern.lantern.model.LanternSessionManager: Storing user data ProUser(userId=372788064, token=BBsWlZSW3, referral=8YXDWM, email=, userStatus=, code=8YXDWM, locale=en_US, subscription=, expiration=0, devices=[], userLevel=)
07-03 14:02:57.461 26562 26806 D MainActivity: Successfully fetched payment methods with payment methods: [PaymentMethods(method=CreditCard, providers=[ProviderInfo(name=Stripe, data={pubKey=xx}, logoUrl=[https://imagedelivery.net/sB6Q2DOuXQsFvrpwTks_kA/e02a8c29-20a6-478f-ed01-e93d0dba0800/public, https://imagedelivery.net/sB6Q2DOuXQsFvrpwTks_kA/94870838-0129-417c-d65a-276422eac900/public, https://imagedelivery.net/sB6Q2DOuXQsFvrpwTks_kA/f56ce1a8-96d6-4528-fdc6-da4605f1c500/public])])] and plans {1y-usd-10=ProPlan(id=1y-usd-10, description=One Year Plan, price={usd=4800}, priceWithoutTax={}, bestValue=false, duration={days=0, months=0, years=1}, discount=0.0, renewalBonusExpected={days=0, months=0}, expectedMonthlyPrice={usd=400}, renewalText=, totalCost=$48, currencyCode=usd, oneMonthCost=$4.00), 2y-usd-10=ProPlan(id=2y-usd-10, description=Two Year Plan, price={usd=8700}, priceWithoutTax={}, bestValue=true, duration={days=0, months=0, years=2}, discount=0.0925, renewalBonusExpected={days=0, months=0}, expectedMonthlyPrice={usd=363}, renewalText=, totalCost=$87, currencyCode=usd, oneMonthCost=$3.63)}

Do you wanna take it for a spin and see how it works for you?

[atavism]

@atavism I think you know better on this, So the issue is this events never gets a callback, It only gets callbacks when user install the app for the first time After that is never callback,

Supported currencies should be updated after Lantern starts now

[jigar-f]

@atavism Taking a look now

[jigar-f]

So I found that is you pass devices as null then you still crash, So I added this, so even if we get an exception we catch it and then return some basic details, So at least the app does not crash.

[atavism]

To test this, I set devices to null in the user data JSON response, and another exception is thrown in the catch block (it looks like the email is missing):

07-04 07:21:42.640  1501  1790 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String com.google.gson.JsonElement.getAsString()' on a null object reference
07-04 07:21:42.640  1501  1790 E AndroidRuntime: 	at org.getlantern.lantern.model.LanternHttpClient$userData$1.onSuccess(LanternHttpClient.kt:104)
07-04 07:21:42.640  1501  1790 E AndroidRuntime: 	at org.getlantern.lantern.model.LanternHttpClient$proRequest$1.onResponse(LanternHttpClient.kt:321)
07-04 07:21:42.640  1501  1790 E AndroidRuntime: 	at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519)
07-04 07:21:42.640  1501  1790 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
07-04 07:21:42.640  1501  1790 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
07-04 07:21:42.640  1501  1790 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:1012)

[atavism]

@jigar-f What do you think of this change to add and make use of a tryParseJson utility method that catches and logs any exception? #1117

[jigar-f]

@atavism Added a more few changes on top of your changes, Do take look at them and let me know, I am happy to merge this and upload the build. Let me know.

[atavism]

@atavism Added a more few changes on top of your changes, Do take look at them and let me know, I am happy to merge this and upload the build. Let me know.

Thanks for making these changes! I just had a quick follow-up PR but LGTM otherwise #1117

[jigar-f]

@atavism Also if all changes look good, You can go ahead and merge, if needed you can upload the build as well,

[atavism]

Thanks, @jigar-f! Yep, the changes here LGTM. I will put out a 7.8.9 release today