Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bill anniversary subscriptions #366

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

vincent-pochet
Copy link
Collaborator

Context

We want to add the ability to choose to bill users at subscription date anniversary and not only on a calendar basis.

Changes

The objective of this pull request is to take anniversary subscriptions into account in the BillingService

It will:

  • Bill weekly subscriptions on their weekly anniversary day
  • Bill monthly subscriptions on their monthly anniversary day, taking into account month duration for subscription day > 28
  • Bill yearly subscriptions on their yearly anniversary day, taking into account year duration for subscription = February 29th when year is not a leap year
  • Bill fees for yearly subscriptions with monthly fee billing on their monthly anniversary taking into account month duration for subscription day > 28

Related resources

This PR follows:

@vincent-pochet vincent-pochet added the Subscription Relation to the Subscriptions label Aug 5, 2022
@vincent-pochet vincent-pochet self-assigned this Aug 5, 2022
@vincent-pochet vincent-pochet force-pushed the feature/subscription-anniversary-billing branch from 031453c to dcce441 Compare August 8, 2022 07:57
@vincent-pochet vincent-pochet merged commit bd3b211 into main Aug 8, 2022
@vincent-pochet vincent-pochet deleted the feature/subscription-anniversary-billing branch August 8, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subscription Relation to the Subscriptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants