feat: Add new date service to compute bounds for subscription and charge fees #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
added
Subscription
rsempe
reviewed
Aug 2, 2022
rsempe
reviewed
Aug 2, 2022
rsempe
reviewed
Aug 3, 2022
rsempe
reviewed
Aug 3, 2022
rsempe
reviewed
Aug 3, 2022
rsempe
reviewed
Aug 3, 2022
rsempe
reviewed
Aug 3, 2022
|
Just a general thought: Do you think extracting that logic into 3 smaller classes (weekly, monthly and yearly) can be interesting? |
Yeah, good suggestion, it could make it a bit easier to read. Let's try it! |
vincent-pochet
force-pushed
the
feature/subscription-date-service
branch
from
39ecc41 to
850285e
Compare
rsempe
approved these changes
Aug 4, 2022
This was referenced Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to add the ability to choose to bill users at subscription date anniversary and not only on a calendar basis.
Changes
The objective of this pull request is to introduce a new
Subscriptions::DatesService.This service is responsible for computing all bounds for invoice and related subscription and charge fees.
It exposes few methods:
from_date: compute the lower bound of an invoicing period based on a provided timestamp and subscriptionto_date: compute the upper bound of an invoicing period based on a provided timestamp and subscriptioncharges_from_date: compute the lower bound of an invoicing period for charges based on a provided timestamp and subscription. It allows to handle thebill_charge_monthlycase for yearly plansnext_end_of_period: compute the next end of period for a given subscription and dateNote: The service is not yet used in invoicing services. This will come with a latter change
Related resources
This PR follows the previous one #352 to update the subscription data model.