misc(payment): Avoid error webhooks on small amount failure #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
misc-avoid-error-webhook-for-small-payment-amount
branch
from
e30f35c to
0604e13
Compare
rsempe
approved these changes
Dec 23, 2024
vincent-pochet
deleted the
misc-avoid-error-webhook-for-small-payment-amount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of the recent payment handling refactoring.
It makes sure that failed payment attempts with an
amount_too_smallerror does not lead to an error webhook but only keeps the payment with afailedstatusandpendingpayable_payment_status. allowing reprocessing of the payment or grouping in a payment request, without spamming the organization owner