misc(payment): Avoid error webhooks on small amount failure

app/services/invoices/payments/create_service.rb

@@ -34,11 +34,11 @@ def call
           payment_provider_id: current_payment_provider.id,
           payment_provider_customer_id: current_payment_provider_customer.id,
           amount_cents: invoice.total_amount_cents,
-          amount_currency: invoice.currency
+          amount_currency: invoice.currency,
+          status: "pending"
         ).find_or_create_by!(
           payable: invoice,
-          payable_payment_status: "pending",
-          status: "pending"
+          payable_payment_status: "pending"
         )
 
         result.payment = payment
@@ -56,9 +56,9 @@ def call
         result
       rescue BaseService::ServiceFailure => e
         result.payment = e.result.payment
-        deliver_error_webhook(e.result)
 
         if e.result.payment.payable_payment_status&.to_sym != :pending
+          deliver_error_webhook(e.result)
           update_invoice_payment_status(payment_status: e.result.payment.payable_payment_status)
         end
 

spec/services/invoices/payments/create_service_spec.rb

@@ -250,7 +250,7 @@
           end
         end
 
-        it "re-reaise the error and delivers an error webhook" do
+        it "updates the invoice payment status and does not delivers an error webhook" do
           result = create_service.call
 
           expect(result).to be_success
@@ -262,6 +262,8 @@
 
           expect(provider_class).to have_received(:new)
           expect(provider_service).to have_received(:call!)
+
+          expect(SendWebhookJob).not_to have_been_enqueued
         end
       end
     end