Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dunning): Fix unique validations on dunning campaign #2865

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

rsempe
Copy link
Collaborator

@rsempe rsempe commented Nov 25, 2024

Roadmap

👉 https://getlago.canny.io/feature-requests/p/set-up-payment-retry-logic

👉 https://getlago.canny.io/feature-requests/p/send-reminders-for-overdue-invoices

Context

We want to automate dunning process so that our users don't have to look at each customer to maximize their chances of being paid retrying payments of overdue balances and sending email reminders.

We are extending dunning campaigns management to edit and delete campaigns.

Description

The goal of this PR is to change existing unique constraints on DunningCampaign and DunningCampaignThreshold to take into consideration the deleted_at value.

@rsempe rsempe force-pushed the feat/auto-dunning-validations branch from 3e04f85 to fbe3fa4 Compare November 25, 2024 20:30
@rsempe rsempe force-pushed the feat/auto-dunning-validations branch from fbe3fa4 to b6a3df4 Compare November 26, 2024 08:42
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rsempe rsempe merged commit a9cbf06 into main Nov 26, 2024
6 checks passed
@rsempe rsempe deleted the feat/auto-dunning-validations branch November 26, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants