feat(dunning): Fix unique validation on dunning campaign threshold cu…

…rrency

app/models/dunning_campaign_threshold.rb

@@ -10,7 +10,9 @@ class DunningCampaignThreshold < ApplicationRecord
 
   validates :amount_cents, numericality: {greater_than_or_equal_to: 0}
   validates :currency, inclusion: {in: currency_list}
-  validates :currency, uniqueness: {scope: :dunning_campaign_id}, unless: :deleted_at
+  validates :currency,
+    uniqueness: {conditions: -> { where(deleted_at: nil) }, scope: :dunning_campaign_id},
+    unless: :deleted_at
 
   default_scope -> { kept }
 end

spec/models/dunning_campaign_threshold_spec.rb

@@ -18,15 +18,15 @@
     let(:dunning_campaign) { create(:dunning_campaign) }
 
     it "validates uniqueness of currency scoped to dunning_campaign_id excluding deleted records" do
-      create(:dunning_campaign_threshold, currency:, dunning_campaign:)
-      new_record = build(:dunning_campaign_threshold, currency:, dunning_campaign:)
-
-      expect(new_record).not_to be_valid
-      expect(new_record.errors[:currency]).to include("value_already_exist")
-
-      # Records with deleted_at set should not conflict
       deleted_record = create(:dunning_campaign_threshold, :deleted, currency:, dunning_campaign:)
       expect(deleted_record).to be_valid
+
+      record1 = create(:dunning_campaign_threshold, currency:, dunning_campaign:)
+      expect(record1).to be_valid
+
+      record2 = build(:dunning_campaign_threshold, currency:, dunning_campaign:)
+      expect(record2).not_to be_valid
+      expect(record2.errors[:currency]).to include("value_already_exist")
     end
   end