forked from jclarke0000/MMM-DarkSkyForecast
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modul doesnt load #1
Open
matze6486
wants to merge
47
commits into
gerjomarty:master
Choose a base branch
from
MarcLandis:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,830
−4,083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename module to MMM-OpenWeatherMapForecast - remove deprecated request dependency and use needle instead - remove npm dependency
For me its also not working ! |
looks like the version check is 2.2.0, but we are only at 2.1.7 think the check should be 2.1.0 (when templating was introduced) |
…con set 6 Outlined Animated Marking Dark Sky's animated icon set as legacy only, so options "useAnimatedIcons" and "animateMainIconOnly". You should now use the new animated icons sets. Adding a new config option "mainIconset". To be used instead of the "animateMainIconOnly" option. Allow you to set icon set for only the current weather icon. Correcting a small class error in file MMM-OpenWeatherMapForecast.njk. Changing the iconsets.img image to an animated gif to be able to see new animated icons in the README.md. Big thanks to basmilius who have made available all theses animated icons for free. To see all the available icons, go see is github page https://github.com/basmilius/weather-icons.
Adding new icons sets: "6fa" - Icon set 6 Filled Animated, "6oa" - Icon set 6 Outlined Animated
… payment details, whereas v2.5 does not. to use v3, add "endpoint": "https://api.openweathermap.org/data/3.0/onecall" to module's config in config.js
changed the units and value of precipitation accumulation from millimeters to inches if units are imperial.
Add ```WEATHER_UPDATED``` notification in an attempt to make this work with MMM-RAIN-MAP module
Undo adding the WEATHER_UPDATED notification
Add keywords
indentation
magic mirror > magicmirror2
magicmirror > magicmirror2; michmich > magicmirrororg
magicmirror > magicmirror2
add code type
add code language
Non-substantive changes per recommendations
Update imperial rain/snow accumulation from mm to in
change default. 2.5 being shut down end of May 24. maybe no longer expose endpoint you can add issues section to forks now.. please do.
remove mainiconset from defaults
change default url
Update defaults to eliminate error
found by pure coincidence at https://forum.magicmirror.builders/topic/18956/module-mmm-openweathermapforecast-is-not-running thx to @sdetweil
well, this fix is incomplete, I only posted the quick for user approach.. error COULD be not nullOR error could be null and response.statusCode COULD be NOT 200 if(!error){
if(response.statusCode == 200){ // good
}
else (api error)
}else // some request processing error |
Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.30.1. - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.1...2.30.1) --- updated-dependencies: - dependency-name: moment dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…-2.30.1 Bump moment from 2.29.1 to 2.30.1
Bumps [needle](https://github.com/tomas/needle) from 2.5.2 to 3.3.1. - [Release notes](https://github.com/tomas/needle/releases) - [Commits](https://github.com/tomas/needle/commits) --- updated-dependencies: - dependency-name: needle dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…-3.3.1 Bump needle from 2.5.2 to 3.3.1
It's MIT according to the package.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
i installed your module (clone + npm install) and i use the sample config with my own api and my own lat/long, but the module displays "load" the whole time.
her is my config. maybe you can fix my problem
{
module: "MMM-OpenWeatherMapForecast",
header: "Weather",
position: "top_right",
classes: "default everyone",
disabled: false,
config: {
apikey: "xxxxxxxxxxxxx",
latitude: "51.78",
longitude: "6.12",
iconset: "4c",
concise: false,
forecastLayout: "table"
}
},