Update defaults to eliminate error #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove mainiconset from defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current defaults definition can throw an error in certain circumstances because
mainIconsetrefers todefaults.iconsetwithin the initial definition ofdefaults. As far as I can tell, the reference todefaults.iconsetis never actually needed anyway, as the later code just checks whether there is amainIconsetdefined in the config file, and if not, usesiconset. So I've removedmainIconsetfrom the defaults defintion, which eliminates the error.The error comes up for me when I run MMM-remote-control, which attempts to validate every other module.