Add Customizable layer origin for ol3 wms Fix #1184 #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis got some error due to DDOS to Dyn yesterday -> npm ERR! network getaddrinfo ENOTFOUND github.com |
mbarto
suggested changes
Oct 25, 2016
| @@ -59,17 +59,21 @@ Layers.registerType('wms', { | |||
| }) | |||
| }); | |||
| } | |||
| const mapSrs = map && map.getView() && map.getView().getProjection() && map.getView().getProjection() && map.getView().getProjection().getCode() || 'EPSG:3857'; | |||
There was a problem hiding this comment.
Could you remove duplicated map.getView().getProjection() check?
There was a problem hiding this comment.
Sure ! I'am not too proud of those lines... :(
mbarto
approved these changes
Oct 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR allow the customisation of origin of WMS Layer in OL3. This is related to #1184.
This PR configure also the correct resolutions of the map to the tilegrid instead of default OL3 resolutions.
Regards,