-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to extend esbuild options #51
Conversation
Thanks for the PR! Are there esbuild options you need to set besides Please also update the README with the new adapter configuration option. |
No problem. The two I've come across so far are Would you prefer it typed to just those two?
|
Yep, only have those in the typings, and only pass those additional options to esbuild instead of spreading the whole object. Can you also open an issue with the use cases this is solving for you? This will help me in the future to understand why those options are exposed if I ever remove/replace esbuild. |
Adding esbuild options to readme.
Fixes #56 |
I've added the use case for both options. I did see there have been some changes with the azure blob sdk, since I first ran into the need for |
Thanks for opening the issue. Yes, please update this PR to only add |
This is released in 0.9.0. Thanks for your patience! |
From reading some other issues, it sounds like you may be planning to remove esbuild all together. However, in the meantime, I keep running into scenarios that require some specific esbuild options (such as
external
). This PR allows you to add to the default options: