Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for additional esbuild options: exlude and keepNames #56

Closed
zjpalasz opened this issue Aug 1, 2022 · 1 comment
Closed

Need for additional esbuild options: exlude and keepNames #56

zjpalasz opened this issue Aug 1, 2022 · 1 comment

Comments

@zjpalasz
Copy link
Contributor

zjpalasz commented Aug 1, 2022

Currently, when trying to bundle node-postgres, the following error occurs:

node_modules/pg/lib/native/client.js:4:21: error: Could not resolve "pg-native" (mark it as external to exclude it from the bundle, or surround it with try/catch to handle the failure at run-time)

The only solution I've come across is to exclude: ['pg-native'] via the esbuild options.

Additionally, when trying to bundle azure/storage-blob, the following error occurs:

Error: TypeError: Expected signal to be an instanceof AbortSignal

It seems to be related to the sdk's dependency on node-fetch as noted here. The suggestion of using keepNames: true, seems to resolve the issue.

@geoffrich
Copy link
Owner

Closed by #51. Please open another issue for keepNames if you find that it is still needed, per #51 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants