Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JavaScript error when the map panel is loaded in a hidden ExtJS tab #367

Merged
merged 1 commit into from
Nov 4, 2015

Conversation

vog
Copy link
Contributor

@vog vog commented Nov 2, 2015

When the map panel is loaded in an initially hidden ExtJS tab, the owner tree is not yet rendered, so call to "node.getOwnerTree()" returns undefined. This caused an error message when trying to call
"node.getOwnerTree().getChecked()".

When the map panel is loaded in an initially hidden ExtJS tab, the
owner tree is not yet rendered, so call to "node.getOwnerTree()"
returns undefined.  This caused an error message when trying to call
"node.getOwnerTree().getChecked()".
@chrismayer
Copy link
Contributor

Hi @vog.

Thanks for your contribution! This looks good to me, but I would like to hear a little comment of @KaiVolland since he was also involved a lot in this part of the library (and of course of everyone else).

Another important point: Did you already sign a Contributor Agreement? The GeoExt project requires that all contributors sign the agreement below and email a scanned copy to the GeoExt Project Steering Committee (psc [at] geoext.org). You can donwload it here

@marcjansen
Copy link
Member

In addition to @chrismayer's comments, will everything work as expected once the panel is shown? Or do we need a one time listener on the show event?

Note for possible mergers: this may need a backport to the stable branch.

@KaiVolland
Copy link
Contributor

It seems to just avoid the javascript error and not changing anything, so i don't see any disadvantages of this change. When @marcjansen s question is answererd and the Contributor Agreement is signed we should merge this.

@vog
Copy link
Contributor Author

vog commented Nov 4, 2015

I can confirm that I tested this patch and that it is used in an application for a customer.

Regarding the Contributor Agreement, I believe I already signed it. Also note that this is not my first pull request on geoext2: #19, #21, #61, #170, #171

@marcjansen
Copy link
Member

this is not my first pull request on geoext2: …

You must have switched avatars then :-)

This is good to go then. Thanks for this contribution, @vog.

marcjansen added a commit that referenced this pull request Nov 4, 2015
Fix JavaScript error when the map panel is loaded in a hidden ExtJS tab
@marcjansen marcjansen merged commit ca8abf1 into geoext:master Nov 4, 2015
@marcjansen
Copy link
Member

Note for possible mergers: this may need a backport to the stable branch.

Here is the backport PR: #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants