Compatibility fix for ExtJS 4.2 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to give this a proper review soon, but this looks fine to me at first sight. |
|
This is good to go. Thanks, @ariskemper & @vog. |
marcjansen
added a commit
that referenced
this pull request
Apr 18, 2013
Compatibility fix for ExtJS 4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When geoext2 is used with ExtJS 4.2, the config option
layout: 'fit'is absolutely required, otherwise the map won't even show up.If you run into this issue, it is very hard to spot. So it makes sense to fix this not just in our application, but also on geoext2 side, by using
layout: 'fit'by default in the main panel class. The attached change does exactly that.