lzma: fix clippy warnings #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@gendx gentle ping for a review. |
gendx
requested changes
Jul 31, 2020
There was a problem hiding this comment.
Hi @lucab, sorry for the delay, I was quite busy this week.
+1 for fixing the new Clippy warnings. Thanks for your help ;)
-1 for pinning a specific Clippy version, as we will forget to upgrade it, and miss new interesting lints in the future. We can always fix new lint errors as they come in the future - I don't think it's breaking that often. Unless Travis' stable is lagging behind the latest Rust stable, can you leave rust: stable in the configuration?
This fixes all linting warnings that were introduced on latest clippy.
|
Amended. |
gendx
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all linting warnings that were introduced on latest clippy.