decode/xz: fix block check method CRC32 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI here is red due to #57, I'll rebase this when the fix there is merged. |
This fixes the XZ decoder in order to properly extract and validate the Block Check field when CRC32 is used. This includes a testcase that was found in the wild and failing to decompress.
lucab
force-pushed
the
ups/xz-block-check-crc32
branch
from
6675bab to
6a99309
Compare
|
Rebased! |
gendx
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This fixes the XZ decoder in order to properly extract and validate
the Block Check field when CRC32 is used.
This includes a testcase that was found in the wild and failing
to decompress.
Testing Strategy
This pull request was tested by...
.lzma,.lzma2,.xzfiles).Supporting Documentation and References
The compressed testcase was part of a larger squashfs image using XZ for data compression.