Ability to configure Docker daemon options #92
Conversation
Since most other instances are capitalized
|
This patch would also cover #84 |
|
Hej, what's the state of this PR ? Would love to see it merged soon ! |
|
devicemapper shouldn't be set as default. |
|
This would also fix some issues I am having, @geerlingguy any chance of a merge? |
|
@geerlingguy is there any chance that PR will be merged? As this is a really nice feature. |
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
|
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
|
Please reopen this |
|
I think you need to create the configuration file before the installation of docker in the task? I needed that for this to work for me locally. |
|
This pull request is no longer marked for closure. |
| - name: Ensure /etc/docker/ directory exists. | ||
| file: | ||
| path: /etc/docker | ||
| state: directory |
There was a problem hiding this comment.
The last thing I'd like to make sure to do is not touch the file if the default (docker_daemon_options: {}) is set.
That way (a) existing role users won't have that file wiped out if it currently contains things and they update the role, and (b) people can manage the file on their own simply by not setting the option in this role's vars.
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
|
bump |
|
This issue is no longer marked for closure. |
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
|
bump |
|
This issue is no longer marked for closure. |
|
Closing in favor of #256, which is based on this. |
Resolves #90