Feature Request: allow override of dockerd options

[robbyoconnor]

I love your Ansible Roles -- but the major no-go for me is the fact I can't override the storage driver easily.

[llbbl]

# defaults
docker_default_config:
  storage-driver: overlay2
  log-level: info

# playbook
- name: apply default daemon config
  set_fact:
    docker_json: "{{ docker_default_config | combine(docker_config | default({})) }}"

- name: ensure daemon config file is present
  copy:
    content: |
      {{ docker_json | to_nice_json(indent=2) }}
    dest: /etc/docker/daemon.json
  notify: restart docker

how mongrelion.docker is doing it... but doesn't seem to change daemon.json very reliably.

[llbbl]

FYI devicemapper is depreciated and causing issues.

docker/cli#1424

[stegr04]

This role is installing v18.09.5 for me as of this post. I'm not sure what might have changed since this issue was originally opened but I figured I would share my findings.

I was looking for the same thing (change storage driver) because docker info was showing it was using devicemapper after installing docker with this role. I found this issue and the solutions discussed/created. Awesome!

I started testing Rickkwa's solution (thank you!). It was working as advertised. Then I started testing without the storage options settings (after manually removing docker). I noticed it was still using overlay2. I wasn't expecting that. I then realized the uninstall wasn't removing the /etc/docker/daemon.json file.

Good time for some backgroun... all of the hosts I am testing with had docker previously installed. I think the system was setup this way because prior versions of docker required Kernel v4 on CentOs.

To make sure I wasn't picking up on anything from prior setups I removed /etc/docker and /var/lib/docker. I tested with Rickkwa's again (no storage options again) and it still showed overlay2, remove everything again, tested geerlingguy's role and found it using overlay2.

To see if there was something else I might have been missing I tested geerlingguy's role on a server I haven't touched except to uninstall all docker packages on the machine. It did not have any /etc/docker/daemon.json file but it did still have /var/lib/docker. When I tested against this node docker info showed me it was using devicemapper. So I did the manual uninstall again, cleaned up the /var/lib/docker and /etc/docker/key.json, ran geerlingguy's role and it's using overlay2.

[stale]

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

[robbyoconnor]

@geerlingguy

[stale]

This issue is no longer marked for closure.

[stale]

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

[robbyoconnor]

This issue is not resolved

[stale]

This issue is no longer marked for closure.

[garymoon]

We're after this also, and will be copying tasks from one of the PRs to get around it for now. Would be happy to contribute fixes/cleanup to one of the PRs to get it merged.

[onezeroecho]

Same here, when using Molecule for testing an Ansible playbook which runs Docker containers you have to use storage-driver: vfs because apparently Docker does not support aufs over aufs.

[robbyoconnor]

Same here, when using Molecule for testing an Ansible playbook which runs Docker containers you have to use storage-driver: vfs because apparently Docker does not support aufs over aufs.

@onezeroecho why not overlay2?

[onezeroecho]

@robbyoconnor Doesn't work for my use case, I get the following output during molecule test when I set the storage driver to overlay2 instead of vfs:

TASK [Get Docker container information] ***************************************
failed: [instance] (item=app_rocketchat_1) => {"ansible_loop_var": "item", "changed": false, "item":
"app_rocketchat_1", "msg": "Error connecting: Error while fetching server API version:
('Connection aborted.', ConnectionRefusedError(111, 'Connection refused'))"}

See also Continuous Infrastructure with Ansible, Molecule & TravisCI where they had to do the same thing.

[robbyoconnor]

@onezeroecho interesting

[stale]

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

[robbyoconnor]

bump

…

On 9/27/20 10:21 PM, stale[bot] wrote: This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post <https://www.jeffgeerling.com/blog/2020/enabling-stale-issue-bot-on-my-github-repositories> to see the reasons why I mark issues as stale. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFUMDIDY6IDUA6EY5MCATSH7XKFANCNFSM4FXPO7CA>.

[stale]

This issue is no longer marked for closure.

[stale]

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

[robbyoconnor]

bump

[stale]

This issue is no longer marked for closure.

[MEschenbacher]

I've now come across the same limitation. Will have to either look for another role or work around by ninja-editing the required files.

[damianoneill]

Hi @geerlingguy can you provide a comment please on whether this feature is something that should be added to this role? It's unclear from looking at the thread history (its been running for two years) whether there is any appetite to update the role to support this.

[geerlingguy]

@damianoneill I do think this kind of functionality would be nice to have in this role.

[geerlingguy]

Left one review on the associated PR, other than that this will be good to go!

[stale]

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

[robbyoconnor]

bump

[stale]

This issue is no longer marked for closure.

[geerlingguy]

There's also this PR: #261

[robbyoconnor]

@geerlingguy my issues from closing :)

[jonathantullett]

Is #261 ready for merging @geerlingguy? It would be great to get this included.

[geerlingguy]

This landed in the 4.0.0 release via #256—thanks to everyone for your patience in getting this merged!