webhelper: Port to webkit2gtk #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes missing favicons in webhelper.
cairo_image_surface_get_width() and friends expects a non-const cairo_surface_t.
webkit2gtk-4.0 doesn't exist for gtk2.
Now we depend on the GTK3-only WebKit2Gtk, drop code for compatibility GTK2.
This is supported by WebKit2Gtk itself, and not controllable by the application, so just drop the useless code.
The initial state was incorrect, and although the state was properly updated upon toggling, WebKit doesn't actually use the value itself but tracks toggle operations on its own, so it would not fix itself for subsequent changes either.
GActions are not GInitiallyUnowned, so we have to manually unref them.
This doesn't change anything though, as currently WebKit doesn't actually use that value, and neither do we.
* Reorder calls to be more consistent when it doesn't affect behavior; * Remove unnecessary call setting a default value; * Better manage line length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off work from @hyperair that was merged at some point in #677, but reverted since then (see there). This adds a couple bits on top to fix some issues, and I believe the "meh no GTK2" whining of mine is lost to time and the fact there's no supported webkit for GTK2 anymore anyway.
BEWARE: this has been given little testing in the 2020s, I just rebased, merged a couple branches to the point there diffed empty, and did some very basic testing (it builds, it runs, and seems to work). Take it, leave it, improve it, comment on it, etc. I'll be there try not to forget looking at this for any comment though 😉
NOTE: it's not at 100% feature-parity with the old version, mostly because of API changes regarding the inspector (II[RU]C, docking settings are not as controllable anymore), yet the inspector itself has seen countless improvements of course. But again, maybe things have changed since 2018.
See also #1217.