-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unusable plugins: DevHelp, GeanyPy, Multiterm #1217
Conversation
f709152
to
ae73705
Compare
It feels weird to delete plugins from @b4n, @kugel- and @codebrainz 🙃 I guess you do not intend to update any of those plugins? |
Well to be fair, Geanypy has a dependency that has stated it will never be newer than GTK2, so "upgrading" would be a rewrite. So since it was a rewrite @kugel- replaced Geanypy with Peasy, which is also better, just its not been added to GP. I think its in some distros (Arch AUR at least), but not Debian or Fedora and their derivatives. Similarly IIUC Webkit2 (now just webkit) is a rewrite, and not API compatible, but how much work a port would be I don't know, not simple I guess or it would be done 😭 Probably removing these is the best thing, then anybody who wants/can "upgrade" them can get the source from git tag 1.38 as a reference or starting point and submit a shiny new plugin without having to handle any backwards compatibility. |
From my side you can remove geanypy. Regarding peasy, I would rather ship it with Geany itself rather than g-p. It's not a useful plugin on its own, just enables other plugins written in non-C languages (which can be hosted here). Also because it wraps all of Geany's APIs it's much more tied to Geany relases than normal plugins. |
Good point. |
re WebHelper, I kind of plan to port it to something not dead someday (webkit2), but it's been a long while and it didn't happen, mostly as @elextr mentioned because it means some non-trivial rewrites. Also, I don't actually use that plugin very much (otherwise I probably would have picked this up by then), and mostly wrote it as a feature request if I recall. If people care, I could possibly try and revamp an old webkit2 port attempt (I think Debian had something back in the days as well [edit: #677, but somehow just got reverted with @codebrainz and I nitpicking, and nobody did anything better]), but I wasn't wholly happy about t because it didn't have full feature parity. And who knows, maybe it'd give somebody else ideas. |
@eht16 well done for tricking me into giving it another shot ;) Though you only got bare minimum resurrection from old work, but that doesn't actually don't look that bad, not sure why I never submitted it. |
wrt the others, FWIW I guess that
|
Just needs "somebody" to do it ;-) [Edit: and as I said before, "somebody" can still get it from git if they want it as a starting point even if its removed] |
This wasn't completely intended by me but nice that it worked :). If nobody stops me, I will merge this in a week so that we finally get a green CI again. |
Actually if it's alright with you, I'd rather merge #1224 and see how it goes. I just went over it and fixed a couple of things, and it's actually in a pretty decent shape. And if anybody want to improve what could be missing they could still do. |
@b4n, "that PR"? Which PR? |
Probably #1224 |
ae73705
to
819efce
Compare
@b4n Alright, Webhelper is back in the game. I would like to restart the "merge in about a week counter" to get this done. |
@eht16 Fine with me, I now merged the webhelper part, so at least I got the ball moving again (and I think it's in a fair enough state anyway). BTW I just gave a quick look at multiterm, and it's less trivial than I expected, so it'd require somebody actually motivated to do it. |
DevHelp depends on unavailable WebKitGtk 1.x. GeanyPy and MultiTerm are GTK 2 only.
819efce
to
3c81960
Compare
DevHelp depends on unavailable WebKitGtk 1.x.
GeanyPy and MultiTerm are GTK 2 only.
After we agreed on this, I will take care of updating the website, closing related issues and maybe more references.