-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-209: Replace MockAccumuloStore usages in docs with MapStore #237
Conversation
Blocked until gchq/Gaffer#2520 is merged and pulled into gaffer-docs |
It is worth noting that as this replaces the MockAccumuloStore with the MapStore, a few features that were documented are not supported by the MapStore and therefore, the code was not run but just printed into the docs. These examples are all under the accumulo and spark operation examples, e.g.: Lines 41 to 56 in 3f3b943
Here, the code is not run but the results that were generated are just printed. This is okay as the docs are soon to be all replaced with text anyway. |
The MapStore was chosen as the replacement instead of MiniAccumuloStores for a few reasons. To accommodate these changes, a few parts of the docs had to be "faked" where the operations do not exist within the MapStore (see above #237 (comment)). |
null
Related Issue