Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some stores don't allow Elements as GetElements input #2421

Closed
n3101 opened this issue May 11, 2021 · 0 comments · Fixed by #2508
Closed

Some stores don't allow Elements as GetElements input #2421

n3101 opened this issue May 11, 2021 · 0 comments · Fixed by #2508
Assignees
@t92549
Labels
bug Confirmed or suspected bug map-store Specific to/touches the map-store module
Milestone
v1.19.0

Comments

@n3101
Copy link

n3101 commented May 11, 2021 •
edited by t92549
Loading

(Originally titled: Inconsistent behaviour between Accumulostore & Mapstore)

The GetElements operation in the AccumuloStore (and MockAccumuloStore) seemingly accept input consisting of Edges, but MapStore (and SingleUseMapStore) don't; they insist on them being wrapped as EdgeSeeds. Admittedly the examples in the docs only show EntitySeed/EdgeSeed.

An exploration of this issue also revealed a couple of nullpointerexceptions. See https://github.com/gchq/Gaffer/tree/gh-2421-BugHunt

Further exploration found that this error happened with the Parquet store too
GCHQDev404 added a commit that referenced this issue May 11, 2021
@GCHQDev404
gh-2421 BugHunt
55ec2cb
@n3101 n3101 added this to the v2.0.0 milestone Jul 28, 2021
@t92549 t92549 modified the milestones: v2.0.0, v1.19.0 Sep 14, 2021
t92549 added a commit that referenced this issue Sep 16, 2021
@t92549
gh-2421: Added more testing to BugHunt
fe31015
t92549 added a commit that referenced this issue Sep 17, 2021
@t92549
Merge branch 'develop' into gh-2421-BugHunt
4733dbf
t92549 added a commit that referenced this issue Sep 17, 2021
@t92549
gh-2421: Small fixes to bug hunt
d3b15b0
t92549 added a commit that referenced this issue Sep 17, 2021
@t92549
gh-2421: More fixes for bug hunt
fe04eba
t92549 added a commit that referenced this issue Sep 17, 2021
@t92549
gh-2421: Change MapStore GetElements to handle Elements as well as El…
014885c 
…ementSeeds
@github-actions github-actions bot mentioned this issue Sep 17, 2021
Merged
t92549 added a commit that referenced this issue Sep 17, 2021
@t92549
gh-2421: Changed GetElementsIT to test both seed and element input
67d608a
t92549 added a commit that referenced this issue Sep 17, 2021
@t92549
gh-2421: Made parquet-store consistent too to pass tests
7fd5c96
@t92549 t92549 added bug Confirmed or suspected bug map-store Specific to/touches the map-store module parquet and removed possible-bug labels Sep 17, 2021
@t92549 t92549 changed the title Inconsistent behaviour between Accumulostore & Mapstore Some stores don't allow Elements as GetElements input Sep 17, 2021
p3430233 added a commit that referenced this issue Sep 21, 2021
@p3430233
Merge pull request #2508 from gchq/gh-2421-mapstore-input-edge
897253a 
gh-2421: Change MapStore GetElements to handle Elements
t92549 added a commit that referenced this issue Sep 28, 2021
@t92549
Merge branch 'develop' into gh-2421-BugHunt
0b98776
@t92549 t92549 mentioned this issue Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t92549 t92549

Labels
bug Confirmed or suspected bug map-store Specific to/touches the map-store module
Projects
None yet
Milestone
v1.19.0
Development

Successfully merging a pull request may close this issue.

gh-2421: Change MapStore GetElements to handle Elements gchq/Gaffer
3 participants
@GCHQDev404 @n3101 @t92549